Update to static rounds - #226
Conversation
0e36343 to
d455ffd
Compare
74a3c0a to
ee9eb2b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 90.60% 89.18% -1.43%
==========================================
Files 50 47 -3
Lines 10759 8403 -2356
==========================================
- Hits 9748 7494 -2254
+ Misses 1011 909 -102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7db7079 to
ea905c5
Compare
ea905c5 to
d788761
Compare
|
All contributors have signed the CLA ✍️ ✅ |
| } | ||
| } | ||
|
|
||
| /// Reconstruct `rid` from echoed messages |
There was a problem hiding this comment.
| /// Reconstruct `rid` from echoed messages | |
| // Reconstruct `rid` from echoed messages |
There was a problem hiding this comment.
I intended it to be a doc comment, I think that's fine?
| let r2_ebs = messages.combined_echos::<Round2<P, Id>>(2)?; | ||
| let r2_eb = messages.previous_echo_broadcast::<Round2<P, Id>>(2)?; |
There was a problem hiding this comment.
We discussed this a fair bit during the manul review, but I nonetheless was surprised to see that we have to pass in the 2 here. It's a wart. :/
There was a problem hiding this comment.
The consequence of one round type being able to be used for several actual rounds.
There was a problem hiding this comment.
Yeah I understand it, but still had to pause. It's just a bit of an oddity. Maybe if rounds had "functional" names it'd be less jarring? Like, dunno, "KeyInitRound", "ReshareRound", etc
| @@ -47,6 +39,35 @@ use crate::{ | |||
| }, | |||
| }; | |||
|
|
|||
| /// Analogous to `Iterator::sum()`, but requires a non-empty iterator | |||
| /// (so that it can be used for types with no `default()`, like `Ciphertext`) | |||
There was a problem hiding this comment.
Not sure I understand this comment about Default. Wouldn't an impl Sum for CipherText work?
impl<P: PaillierParams> Sum for Ciphertext<P> {
fn sum<I: Iterator<Item = Self>>(mut iter: I) -> Self {
let mut result = iter.next().unwrap();
for item in iter {
result = result + item;
}
result
}
}
There was a problem hiding this comment.
It'll panic for an empty iterator, and the purpose of these functions is to have a Result instead. We can't return Result from sum().
|
I have read the CLA Document and I hereby sign the CLA |
d788761 to
2d470c3
Compare
2 participants
Use static rounds from entropyxyz/manul#117 and helpers from entropyxyz/manul#113
Also fixes #216 (static round methods use
impl CryptoRngCore)